0001566: Unable to compile under cygwin

(0001717)
michu (reporter)
2007-10-25 05:29

solution (tried with latest svn version)

create new file called fake_getaddrinfo.h with this content:
struct addrinfo {
        int ai_flags; /* AI_PASSIVE, AI_CANONNAME */
        int ai_family; /* PF_xxx */
        int ai_socktype; /* SOCK_xxx */
        int ai_protocol; /* 0 or IPPROTO_xxx for IPv4 and IPv6 */
        size_t ai_addrlen; /* length of ai_addr */
        char *ai_canonname; /* canonical name for hostname */
        struct sockaddr *ai_addr; /* binary address */
        struct addrinfo *ai_next; /* next structure in linked list */
};

static int
fake_getaddrinfo(const char *hostname, struct addrinfo *ai, in_port_t port)
{
        struct hostent *he;
        struct in_addr **ap;
        struct sockaddr_in *sa_in;

        he = gethostbyname(hostname);
        if (!he)
                return (-1);
        ai->ai_family = he->h_addrtype;
        ai->ai_socktype = SOCK_STREAM;
        ai->ai_protocol = 0;
        //ai->ai_addrlen = he->h_length;
        ai->ai_addrlen = sizeof(struct sockaddr_in);
        if (NULL == (ai->ai_addr = malloc(ai->ai_addrlen)))
                return (-1);

        sa_in = (struct sockaddr_in *)ai->ai_addr;
        memset(sa_in, 0, sizeof(struct sockaddr_in));
        sa_in->sin_family = PF_INET;
        sa_in->sin_port = htons(port);
        ap = (struct in_addr **)he->h_addr_list;
        memcpy(&sa_in->sin_addr, *ap, sizeof(struct in_addr));

        ai->ai_next = NULL;
        return (0);
}

static void
fake_freeaddrinfo(struct addrinfo *ai)
{
        free(ai->ai_addr);
}

now edit inputStream_http.c:
-add #include "fake_getaddrinfo.h"
-replace "freeaddrinfo(" with "fake_freeaddrinfo("
-change this line:
//DEBUG(__FILE__ ": Error getting address info: %s\n", ai_strerror(error));
DEBUG(__FILE__ ": Error getting address info: %i\n", error);

that should do the trick

can anyone test this?

cheers michu / www.neophob.com

(0001718)
michu (reporter)
2007-10-25 06:16
edited on: 2007-10-25 06:16

and btw, when you are facing this errors:
$ ./mpd --no-daemon --stdout --verbose
binding to any address
flushing warning messages
done flushing warning messages
current locale is "C"
setting filesystem charset to ISO-8859-1
setFsCharset: fs charset is: ISO-8859-1
reading DB
Bad system call

an export will solve the problem

$ export CYGWIN=server

$ ./mpd --no-daemon --stdout --verbose
binding to any address
flushing warning messages
done flushing warning messages
current locale is "C"
setting filesystem charset to ISO-8859-1
setFsCharset: fs charset is: ISO-8859-1
reading DB
No "audio_output" defined in config file
Attempt to detect audio output device
Attempting to detect a oss audio device
Successfully detected a oss audio device
unable to open oss mixer "/dev/mixer"
using software volume

tadaaa! cheers michu

(0001719)
michu (reporter)
2007-10-25 07:22

but i guess there are some issues left...

interface 0: process command list returned 0
interface 0: closed
interface 0: opened from 127.0.0.1
interface 0: process command "status"
interface 0: command returned 0
interface 0: process command "play "-1""
playlist: play 0:"Daft Punk/Daft Punk Alive 2007/7. Too Long.mp3"
13 [main] mpd 684 C:\Program Files\cygwin\home\mpx\mpd-test\mpd.exe: *** fatal error - MapViewOfFileEx (0x28990000), Win32 er
ror 6. Terminating.
0 [main] mpd 3004 fork: child 684 - died waiting for dll loading, errno 11
player Problems fork()'ing
playlist: stop
interface 0: command returned -1

mpd crash when forking...

(0001779)
michu (reporter)
2007-11-21 06:42

The error "** fatal error - MapViewOfFileEx (0x28990000), Win32 error 6. Terminating." was an cygwin bug and has been fixed in the curren snapshot release. so mpd will run fine under cygwin...

(0001781)
qball (administrator)
2007-11-21 06:55
edited on: 2007-11-21 08:03

I removed block state from the bug, as win32 is not a supported platform.

If you want to supply a patch, please attach it as file.

(if the patch is fine, It will be commited)

(0001841)
michu (reporter)
2007-12-07 08:31

i added the cygwin patch

(0001842)
Avuton Olrich (administrator)
2007-12-07 14:32

Would you make one patch which will take care of it all? Thanks.

(0005713)
Avuton Olrich (administrator)
2010-05-29 02:22

Compiles for mingw now, if git doesn't compile for cygwin, please reopen this bug.

Issue History
Date Modified	Username	Field	Change
2007-09-14 14:35	mattswell	New Issue
2007-09-14 14:35	mattswell	Status	new => assigned
2007-09-14 14:35	mattswell	Assigned To	=> shank
2007-10-25 05:29	michu	Note Added: 0001717
2007-10-25 06:16	michu	Note Added: 0001718
2007-10-25 06:16	michu	Note Edited: 0001718
2007-10-25 07:22	michu	Note Added: 0001719
2007-11-21 06:42	michu	Note Added: 0001779
2007-11-21 06:55	qball	Note Added: 0001781
2007-11-21 06:55	qball	Severity	block => feature
2007-11-21 08:03	qball	Note Edited: 0001781
2007-12-07 08:30	michu	File Added: cygwin.patch
2007-12-07 08:31	michu	Note Added: 0001841
2007-12-07 14:32	Avuton Olrich	Note Added: 0001842
2008-10-16 03:39	cirrus	Assigned To	shank => cirrus
2008-10-25 13:25	Avuton Olrich	Category	Version - GIT => Build
2008-10-25 13:25	Avuton Olrich	Product Version	=> git
2008-11-05 04:04	cirrus	Priority	normal => low
2008-12-04 05:21	cirrus	Relationship added	related to 0001854
2010-05-29 02:22	Avuton Olrich	Note Added: 0005713
2010-05-29 02:22	Avuton Olrich	Status	assigned => resolved
2010-05-29 02:22	Avuton Olrich	Resolution	open => fixed
2010-06-05 21:15	Avuton Olrich	Status	resolved => closed

Notes
(0001717) michu (reporter) 2007-10-25 05:29	solution (tried with latest svn version) create new file called fake_getaddrinfo.h with this content: struct addrinfo { int ai_flags; /* AI_PASSIVE, AI_CANONNAME / int ai_family; / PF_xxx / int ai_socktype; / SOCK_xxx / int ai_protocol; / 0 or IPPROTO_xxx for IPv4 and IPv6 / size_t ai_addrlen; / length of ai_addr / char ai_canonname; /* canonical name for hostname / struct sockaddr ai_addr; /* binary address / struct addrinfo ai_next; /* next structure in linked list / }; static int fake_getaddrinfo(const char hostname, struct addrinfo ai, in_port_t port) { struct hostent he; struct in_addr *ap; struct sockaddr_in sa_in; he = gethostbyname(hostname); if (!he) return (-1); ai->ai_family = he->h_addrtype; ai->ai_socktype = SOCK_STREAM; ai->ai_protocol = 0; //ai->ai_addrlen = he->h_length; ai->ai_addrlen = sizeof(struct sockaddr_in); if (NULL == (ai->ai_addr = malloc(ai->ai_addrlen))) return (-1); sa_in = (struct sockaddr_in )ai->ai_addr; memset(sa_in, 0, sizeof(struct sockaddr_in)); sa_in->sin_family = PF_INET; sa_in->sin_port = htons(port); ap = (struct in_addr )he->h_addr_list; memcpy(&sa_in->sin_addr, ap, sizeof(struct in_addr)); ai->ai_next = NULL; return (0); } static void fake_freeaddrinfo(struct addrinfo *ai) { free(ai->ai_addr); } now edit inputStream_http.c: -add #include "fake_getaddrinfo.h" -replace "freeaddrinfo(" with "fake_freeaddrinfo(" -change this line: //DEBUG(__FILE__ ": Error getting address info: %s\n", ai_strerror(error)); DEBUG(__FILE__ ": Error getting address info: %i\n", error); that should do the trick can anyone test this? cheers michu / www.neophob.com

(0001718) michu (reporter) 2007-10-25 06:16 edited on: 2007-10-25 06:16	and btw, when you are facing this errors: $ ./mpd --no-daemon --stdout --verbose binding to any address flushing warning messages done flushing warning messages current locale is "C" setting filesystem charset to ISO-8859-1 setFsCharset: fs charset is: ISO-8859-1 reading DB Bad system call an export will solve the problem $ export CYGWIN=server $ ./mpd --no-daemon --stdout --verbose binding to any address flushing warning messages done flushing warning messages current locale is "C" setting filesystem charset to ISO-8859-1 setFsCharset: fs charset is: ISO-8859-1 reading DB No "audio_output" defined in config file Attempt to detect audio output device Attempting to detect a oss audio device Successfully detected a oss audio device unable to open oss mixer "/dev/mixer" using software volume tadaaa! cheers michu

(0001719) michu (reporter) 2007-10-25 07:22	but i guess there are some issues left... interface 0: process command list returned 0 interface 0: closed interface 0: opened from 127.0.0.1 interface 0: process command "status" interface 0: command returned 0 interface 0: process command "play "-1"" playlist: play 0:"Daft Punk/Daft Punk Alive 2007/7. Too Long.mp3" 13 [main] mpd 684 C:\Program Files\cygwin\home\mpx\mpd-test\mpd.exe: *** fatal error - MapViewOfFileEx (0x28990000), Win32 er ror 6. Terminating. 0 [main] mpd 3004 fork: child 684 - died waiting for dll loading, errno 11 player Problems fork()'ing playlist: stop interface 0: command returned -1 mpd crash when forking...

(0001779) michu (reporter) 2007-11-21 06:42	The error "** fatal error - MapViewOfFileEx (0x28990000), Win32 error 6. Terminating." was an cygwin bug and has been fixed in the curren snapshot release. so mpd will run fine under cygwin...

(0001781) qball (administrator) 2007-11-21 06:55 edited on: 2007-11-21 08:03	I removed block state from the bug, as win32 is not a supported platform. If you want to supply a patch, please attach it as file. (if the patch is fine, It will be commited)

(0001841) michu (reporter) 2007-12-07 08:31	i added the cygwin patch

(0001842) Avuton Olrich (administrator) 2007-12-07 14:32	Would you make one patch which will take care of it all? Thanks.

(0005713) Avuton Olrich (administrator) 2010-05-29 02:22	Compiles for mingw now, if git doesn't compile for cygwin, please reopen this bug.