0001558: start/stop/start an http stream does not work

(0001603)
sylware (reporter)
2007-08-30 02:27
edited on: 2007-08-30 02:28

I cannot always reproduce the bug. I increased buffer/pre-buffer(256/128) size and all of my http streams played fine, even after a stop. Then I have a huge play latency.

(0001752)
vollmerk (reporter)
2007-11-12 19:08

I've been able to reproduce this bug with the Latest SVN with the following conditions

1) Add http streams to MPD
2) Set Repeat to ON
3) Stop player
4) Invalidate HTTP streams (don't kill network connection, but have it be text files instead of audio files)
5) Hit Play

I straced MPD and this is what I see when I do the above (scrolling past as fast as possible)

select(0, NULL, NULL, NULL, {0, 1000}) = 0 (Timeout)
select(0, NULL, NULL, NULL, {0, 1000}) = 0 (Timeout)

Also Jat asked me to do the following

vollmerk@lanfear:/usr/src/mpd$ ps -C mpd -o state,comm -H
S COMMAND
S mpd
S mpd
S mpd

Last but not least SVN info

vollmerk@lanfear:/usr/src/mpd$ svn info
Path: .
URL: https://svn.musicpd.org/mpd/trunk [^]
Repository Root: https://svn.musicpd.org [^]
Repository UUID: 09075e82-0dd4-0310-85a5-a0d7c8717e4f
Revision: 7034
Node Kind: directory
Schedule: normal
Last Changed Author: qball
Last Changed Rev: 6952
Last Changed Date: 2007-10-03 09:11:01 -0700 (Wed, 03 Oct 2007)

(0001800)
qball (administrator)
2007-11-28 15:22

Can you test with current svn?

(0001802)
qball (administrator)
2007-11-28 15:24

Needs testing.

(0001819)
sylware (reporter)
2007-12-02 12:08

Sorry, on my side I'm really not able to reproduce the issue even with mpd 0.13 (not svn). I have removed my custom sized http buffer.

(0001820)
vollmerk (reporter)
2007-12-03 02:51

This patch definitely fixed the problem I was having, it now hangs for a second or two before returning to normal (more then reasonable behavior considering I'm feeding it garbage)

(0001821)
qball (administrator)
2007-12-03 06:31

Not fixed perfectly, but the best I can do atm.

Issue History
Date Modified	Username	Field	Change
2007-08-29 10:16	sylware	New Issue
2007-08-29 10:16	sylware	Status	new => assigned
2007-08-29 10:16	sylware	Assigned To	=> shank
2007-08-30 02:27	sylware	Note Added: 0001603
2007-08-30 02:28	sylware	Note Edited: 0001603
2007-11-12 19:08	vollmerk	Note Added: 0001752
2007-11-12 19:10	vollmerk	Issue Monitored: vollmerk
2007-11-28 15:22	qball	Note Added: 0001800
2007-11-28 15:24	qball	Note Added: 0001802
2007-11-28 15:24	qball	Assigned To	shank => qball
2007-11-28 15:24	qball	Status	assigned => feedback
2007-12-02 12:08	sylware	Note Added: 0001819
2007-12-03 02:51	vollmerk	Note Added: 0001820
2007-12-03 06:31	qball	Status	feedback => closed
2007-12-03 06:31	qball	Note Added: 0001821
2007-12-03 06:31	qball	Resolution	open => fixed

Notes
(0001603) sylware (reporter) 2007-08-30 02:27 edited on: 2007-08-30 02:28	I cannot always reproduce the bug. I increased buffer/pre-buffer(256/128) size and all of my http streams played fine, even after a stop. Then I have a huge play latency.

(0001752) vollmerk (reporter) 2007-11-12 19:08	I've been able to reproduce this bug with the Latest SVN with the following conditions 1) Add http streams to MPD 2) Set Repeat to ON 3) Stop player 4) Invalidate HTTP streams (don't kill network connection, but have it be text files instead of audio files) 5) Hit Play I straced MPD and this is what I see when I do the above (scrolling past as fast as possible) select(0, NULL, NULL, NULL, {0, 1000}) = 0 (Timeout) select(0, NULL, NULL, NULL, {0, 1000}) = 0 (Timeout) Also Jat asked me to do the following vollmerk@lanfear:/usr/src/mpd$ ps -C mpd -o state,comm -H S COMMAND S mpd S mpd S mpd Last but not least SVN info vollmerk@lanfear:/usr/src/mpd$ svn info Path: . URL: https://svn.musicpd.org/mpd/trunk [^] Repository Root: https://svn.musicpd.org [^] Repository UUID: 09075e82-0dd4-0310-85a5-a0d7c8717e4f Revision: 7034 Node Kind: directory Schedule: normal Last Changed Author: qball Last Changed Rev: 6952 Last Changed Date: 2007-10-03 09:11:01 -0700 (Wed, 03 Oct 2007)

(0001800) qball (administrator) 2007-11-28 15:22	Can you test with current svn?

(0001802) qball (administrator) 2007-11-28 15:24	Needs testing.

(0001819) sylware (reporter) 2007-12-02 12:08	Sorry, on my side I'm really not able to reproduce the issue even with mpd 0.13 (not svn). I have removed my custom sized http buffer.

(0001820) vollmerk (reporter) 2007-12-03 02:51	This patch definitely fixed the problem I was having, it now hangs for a second or two before returning to normal (more then reasonable behavior considering I'm feeding it garbage)

(0001821) qball (administrator) 2007-12-03 06:31	Not fixed perfectly, but the best I can do atm.

Relationships